Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make IO test mock data path absolute #647

Merged

Conversation

stephenswat
Copy link
Member

The current IO mock data path is relative, which breaks down if data is not stored in the data/ directory. This commit makes the path absolute via some CMake code to ensure that it is treated as an absolute path.

The current IO mock data path is relative, which breaks down if data is
not stored in the `data/` directory. This commit makes the path absolute
via some CMake code to ensure that it is treated as an absolute path.
@stephenswat stephenswat added bug Something isn't working tests Make sure the code keeps working labels Jul 22, 2024
@stephenswat stephenswat requested a review from beomki-yeo July 22, 2024 12:39
Copy link
Contributor

@beomki-yeo beomki-yeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@stephenswat stephenswat enabled auto-merge July 22, 2024 12:46
@stephenswat stephenswat merged commit bb0df91 into acts-project:main Jul 22, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tests Make sure the code keeps working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants