feat: make building of tracccc::io optional (but on by default) #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenswat
requested changes
Jul 24, 2024
Co-authored-by: Stephen Nicholas Swatman <stephenswat@gmail.com>
Co-authored-by: Stephen Nicholas Swatman <stephenswat@gmail.com>
stephenswat
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to include traccc (temporarily) as a plugin to ACTS, I suggest to add the CMake flag
TRACCC_BUILD_IOWhen switched off, neither the IO module and dependent examples/testing/performance modules will be built, but none of those are needed in the ACTS integration effort, where event data and geometry are translated in memory.
This also breaks (some of?) the circular dependency for the digitisation IO.