Increase minimum CMake version to 3.22 #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenswat
added
bug
krasznaa
requested changes
Aug 1, 2024
There was a problem hiding this comment.
Unfortunately this is not enough. 😦 3.22 might be enough for the host code compilation, but not for CUDA. 😦
https://gitlab.kitware.com/cmake/cmake/-/blob/v3.22.0/Modules/Compiler/NVIDIA-CUDA.cmake
We need to go all the way to 3.26 for C++20 support with CUDA. 😱
https://gitlab.kitware.com/cmake/cmake/-/blob/v3.26.0/Modules/Compiler/NVIDIA-CUDA.cmake
I.e., this PR should request 3.26 in: https://github.com/acts-project/traccc/blob/main/device/cuda/CMakeLists.txt
stephenswat
force-pushed
the
build/cmake_min_3_22
branch
from
f692387 to
e7f5108
Compare
|
I added a CMake 3.26 requirement for the CUDA library. |
stephenswat
force-pushed
the
build/cmake_min_3_22
branch
from
e7f5108 to
fa990be
Compare
Earlier versions of CMake were unable to properly configure GCC for C++20 compilation, opting to add the `-std=c++2a` flag instead of the `-std=c++20` flag which broke the build. CMake 3.22 correctly sets the C++20 flag, and as such we are setting this as our new minimum version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier versions of CMake were unable to properly configure GCC for C++20 compilation, opting to add the
-std=c++2aflag instead of the-std=c++20flag which broke the build. CMake 3.22 correctly sets the C++20 flag, and as such we are setting this as our new minimum version.