Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use traccc scalar type in seeding config #668

Merged

Conversation

stephenswat
Copy link
Member

The maximum scattering angle was being calculated as a floating point values, which was causing errors in the Acts integration. This minor change updates this to use the generic scalar type, which can be synchronised with the Acts scalar type.

The maximum scattering angle was being calculated as a floating point
values, which was causing errors in the Acts integration. This minor
change updates this to use the generic scalar type, which can be
synchronised with the Acts scalar type.
@stephenswat stephenswat added the bug Something isn't working label Aug 6, 2024
@beomki-yeo beomki-yeo merged commit c0696fe into acts-project:main Aug 6, 2024
23 checks passed
@krasznaa
Copy link
Member

krasznaa commented Aug 6, 2024

Curious. 🤔 For "configuration types" I generally prefer to just use float directly. What's the exact issue that we're solving in Acts with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants