Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Externals Update, main branch (2024.08.14.) #673

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

krasznaa
Copy link
Member

This is mainly to update to the latest VecMem version, to help with a build issue discovered in #627. (Because of that, it's relatively urgent.)

But while I was at it, I also updated to the latest version of GoogleTest. Which then also necessitated adding an <iomanip> include, which was missing so far from one of the tests.

@krasznaa krasznaa added build This relates to the build system tests Make sure the code keeps working high priority labels Aug 14, 2024
@krasznaa krasznaa force-pushed the ExternalsUpdate-main-20240814 branch from 359178d to 975239e Compare August 14, 2024 06:16
Copy link
Contributor

@beomki-yeo beomki-yeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Which was highlighted by the switch to a newer GoogleTest
version.
@krasznaa krasznaa force-pushed the ExternalsUpdate-main-20240814 branch from 975239e to cc3a3d2 Compare August 14, 2024 14:27
@krasznaa krasznaa merged commit bd8969f into acts-project:main Aug 14, 2024
23 checks passed
@krasznaa krasznaa deleted the ExternalsUpdate-main-20240814 branch August 14, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build This relates to the build system high priority tests Make sure the code keeps working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants