Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Only apply -Wfloat-conversion if traccc is top-level #676

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

paulgessinger
Copy link
Member

Also changes -pedantic to -Wpedantic which I think was a typo (they're different options)

@paulgessinger paulgessinger requested a review from krasznaa August 14, 2024 13:13
Copy link
Member

@krasznaa krasznaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fairly confused...

@paulgessinger
Copy link
Member Author

Revertded the -pedantic change @krasznaa

Copy link
Member

@krasznaa krasznaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, let's do this until the warnings are removed from the Acts headers. 👍

@krasznaa
Copy link
Member

Don't forget to rebase the PR! Other than that, I'm good with this.

Also changes `-pedantic` to `-Wpedantic` which I think was a typo
(they're different options)
@krasznaa krasznaa enabled auto-merge August 15, 2024 12:26
@krasznaa krasznaa merged commit 3b147ca into acts-project:main Aug 15, 2024
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants