Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make track param estimation more accurate #684

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

beomki-yeo
Copy link
Contributor

Current track parameter estimation is based on approximation and this PR removes such approximation.
I believe the gain from making it more accurate outweights the loss from slightly longer computation time

Following acts-project/acts#2982

Copy link
Member

@krasznaa krasznaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is a miniscule part of our execution time. If this change provides an improvement for the code's physics performance, I'm okay with a few more floating-point calculations. 👍

@beomki-yeo beomki-yeo force-pushed the fix-track-param-esti branch from d1f228c to 972418b Compare August 16, 2024 12:41
Copy link
Member

@krasznaa krasznaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@krasznaa krasznaa merged commit c3b9e82 into acts-project:main Aug 16, 2024
23 checks passed
@beomki-yeo beomki-yeo changed the title Makee track param estimation more accurate Make track param estimation more accurate Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants