Fix integer comparison bugs in device CKF #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenswat
added
bug
stephenswat
force-pushed
the
fix/ckf_numerical_limits
branch
from
dcb8712 to
20a8b3c
Compare
|
@krasznaa updated as you requested. |
beomki-yeo
approved these changes
Sep 2, 2024
stephenswat
force-pushed
the
fix/ckf_numerical_limits
branch
from
20a8b3c to
6d203b4
Compare
This commit fixes a few bugs in the device CKF to do with the integral representation of the previous step number. Firstly, the previous step of step 0 (e.g. some sort of sentinel value) was being inconsistently defined as either the maximum value of a signed int or an unsigned int, and this was stored in an integer, leading to unexpected behaviour. Furthermore, the track building kernel was not correctly checking for the sentinel value, but rather looking for values smaller than 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a few bugs in the device CKF to do with the integral representation of the previous step number. Firstly, the previous step of step 0 (e.g. some sort of sentinel value) was being inconsistently defined as either the maximum value of a signed int or an unsigned int, and this was stored in an integer, leading to unexpected behaviour. Furthermore, the track building kernel was not correctly checking for the sentinel value, but rather looking for values smaller than 0.