Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to detray version v0.74.2 #696

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Update to detray version v0.74.2 #696

merged 1 commit into from
Sep 10, 2024

Conversation

niermann999
Copy link
Contributor

@niermann999 niermann999 commented Sep 5, 2024 •
edited
Loading

Update to detray v0.74.2
Main changes:

  • Remove distinction between free vector and free track parameters and refactor track param class interface a bit
  • Move the transform index onto the barcode
  • fixed window navigation (will remove the navigation buffer, as the navigator can now deal with a static fixed size memory)

@niermann999 niermann999 marked this pull request as ready for review September 6, 2024 15:03
@niermann999

This comment was marked as outdated.

Sign in to view
@stephenswat stephenswat changed the title Update to version v0.74.0 Update to detray version v0.74.0 Sep 9, 2024
stephenswat
stephenswat requested changes Sep 9, 2024
View reviewed changes
Copy link
Member

@stephenswat stephenswat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a concern about one of the changes. Did you check the physics performance of these changes at all? Otherwise I can have a look into it.

@niermann999 niermann999 force-pushed the ref-update-detray branch 2 times, most recently from 46af9fd to 9897289 Compare September 9, 2024 13:28
@niermann999 niermann999 changed the title Update to detray version v0.74.0 Update to detray version v0.74.1 Sep 9, 2024
stephenswat
stephenswat approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@stephenswat stephenswat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After looking into it with Joana I am happy to approve (as long as the CI is also happy).

@niermann999 niermann999 changed the title Update to detray version v0.74.1 Update to detray version v0.74.2 Sep 10, 2024
@stephenswat stephenswat merged commit e7a03e9 into acts-project:main Sep 10, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenswat stephenswat stephenswat approved these changes

@beomki-yeo beomki-yeo Awaiting requested review from beomki-yeo

@krasznaa krasznaa Awaiting requested review from krasznaa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niermann999 @stephenswat