Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing files to CMakeLists.txt #697

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

beomki-yeo
Copy link
Contributor

Neza has reported that fatal error: traccc/clusterization/device/ccl_kernel_definitions.hpp: No such file or directory appears in the client build.

I think it is because the corresponding files are missing in the CMakeLists.txt (not 100% sure though)

@beomki-yeo
Copy link
Contributor Author

It turns out that it does not solve the issue of Neza 🫠

Copy link
Member

@stephenswat stephenswat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, adding header files to a target like this doesn't actually do anything. I believe Attila insists on this because he uses an IDE which relies on this information, but it doesn't change the compilation at all. Happy to approve, though.

@stephenswat stephenswat merged commit 7f49563 into acts-project:main Sep 10, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants