Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace hit_id column of cell with measurement_id #699

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

beomki-yeo
Copy link
Contributor

@beomki-yeo beomki-yeo commented Sep 12, 2024

Part of #692

hit_id is not used anymore in ACTS csv data format so I suggest replacing them with right one.

It is not directly related with the purpose of this PR, but I also changed the geometry_id of mock_data to a value compatible with ODD. This will be needed in the next PRs with event_map refactoring

@beomki-yeo
Copy link
Contributor Author

Any review?

@stephenswat stephenswat merged commit 884457a into acts-project:main Sep 17, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants