Replace hit_id column of cell with measurement_id #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beomki-yeo
force-pushed
the
fix-cell-io-type
branch
from
e6bf1cc to
beeb57b
Compare
beomki-yeo
force-pushed
the
fix-cell-io-type
branch
from
beeb57b to
cd44ad9
Compare
|
Any review? |
stephenswat
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #692
hit_idis not used anymore in ACTS csv data format so I suggest replacing them with right one.It is not directly related with the purpose of this PR, but I also changed the
geometry_idof mock_data to a value compatible with ODD. This will be needed in the next PRs with event_map refactoring