Attach algebra-plugins define to core target #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, the algebra plugin to be used is selected using a global define in CMake, but this does not carry over when traccc is used as a dependency, e.g. like we do in ACTS. This PR ensures that the define is instead added as a target-specific public definition, which will resolve this issue.
paulgessinger
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the algebra plugin to be used is selected using a global define in CMake, but this does not carry over when traccc is used as a dependency, e.g. like we do in ACTS. This PR ensures that the define is instead added as a target-specific public definition, which will resolve this issue.