Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach algebra-plugins define to core target #704

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

stephenswat
Copy link
Member

Right now, the algebra plugin to be used is selected using a global define in CMake, but this does not carry over when traccc is used as a dependency, e.g. like we do in ACTS. This PR ensures that the define is instead added as a target-specific public definition, which will resolve this issue.

@stephenswat stephenswat added the build This relates to the build system label Sep 19, 2024
Right now, the algebra plugin to be used is selected using a global
define in CMake, but this does not carry over when traccc is used as a
dependency, e.g. like we do in ACTS. This PR ensures that the define is
instead added as a target-specific public definition, which will resolve
this issue.
@paulgessinger paulgessinger merged commit 595dad9 into acts-project:main Sep 20, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build This relates to the build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants