-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Access track parameters in sorted order for CKF propagation #706
Conversation
ed41ac2
to
9b651e5
Compare
8c8af7d
to
765e968
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be clear, as I said on Friday, I'm absolutely happy with this development. It's just some of the technicalities that I have comments on. 😉
device/common/include/traccc/finding/device/get_sort_key_value.hpp
Outdated
Show resolved
Hide resolved
device/common/include/traccc/finding/device/propagate_to_next_surface.hpp
Outdated
Show resolved
Hide resolved
765e968
to
0285d8d
Compare
@krasznaa Can you approve if it is OK? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment about the documentation you may or may not fix. I don't feel strongly enough about it to hold up the PR just because of it. 👍
0285d8d
to
90a3e3c
Compare
CI seems stuck again - let me just push this thru... |
CKF update part of #689, for easier review