Access track parameters in sorted order for CKF propagation #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beomki-yeo
force-pushed
the
sort-track-params-4
branch
3 times, most recently
from
ed41ac2 to
9b651e5
Compare
beomki-yeo
force-pushed
the
sort-track-params-4
branch
2 times, most recently
from
8c8af7d to
765e968
Compare
krasznaa
requested changes
Sep 23, 2024
device/common/include/traccc/finding/device/get_sort_key_value.hpp
Outdated
Show resolved
Hide resolved
device/common/include/traccc/finding/device/propagate_to_next_surface.hpp
Outdated
Show resolved
Hide resolved
beomki-yeo
force-pushed
the
sort-track-params-4
branch
from
765e968 to
0285d8d
Compare
|
@krasznaa Can you approve if it is OK? |
krasznaa
approved these changes
Sep 24, 2024
beomki-yeo
force-pushed
the
sort-track-params-4
branch
from
0285d8d to
90a3e3c
Compare
|
CI seems stuck again - let me just push this thru... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CKF update part of #689, for easier review