Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access track parameters in sorted order for CKF propagation #706

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

beomki-yeo
Copy link
Contributor

CKF update part of #689, for easier review

@beomki-yeo beomki-yeo force-pushed the sort-track-params-4 branch 3 times, most recently from ed41ac2 to 9b651e5 Compare September 20, 2024 19:40
@beomki-yeo beomki-yeo force-pushed the sort-track-params-4 branch 2 times, most recently from 8c8af7d to 765e968 Compare September 21, 2024 18:18
Copy link
Member

@krasznaa krasznaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be clear, as I said on Friday, I'm absolutely happy with this development. It's just some of the technicalities that I have comments on. 😉

@beomki-yeo
Copy link
Contributor Author

@krasznaa Can you approve if it is OK?

Copy link
Member

@krasznaa krasznaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment about the documentation you may or may not fix. I don't feel strongly enough about it to hold up the PR just because of it. 👍

@beomki-yeo
Copy link
Contributor Author

CI seems stuck again - let me just push this thru...

@beomki-yeo beomki-yeo merged commit e273246 into acts-project:main Sep 24, 2024
18 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants