Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update detray to v0.78.0 #723

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

beomki-yeo
Copy link
Contributor

No description provided.

@beomki-yeo beomki-yeo force-pushed the update-to-detray-v77 branch from 2e6e2c7 to 94ce56e Compare October 2, 2024 16:22
@beomki-yeo
Copy link
Contributor Author

@niermann999

Probably we need to fix this in detray for HIP compilation

/__w/traccc/traccc/build/_deps/detray-src/core/include/detray/utils/bit_encoder.hpp:48:30: error: cannot take address of consteval function 'extract_shift' outside of an immediate invocation
        return (v & mask) >> extract_shift(mask);
                             ^
/__w/traccc/traccc/build/_deps/detray-src/core/include/detray/utils/bit_encoder.hpp:65:26: note: declared here
    static consteval int extract_shift(value_t mask) noexcept {
                         ^
/__w/traccc/traccc/build/_deps/detray-src/core/include/detray/utils/bit_encoder.hpp:57:35: error: cannot take address of consteval function 'extract_shift' outside of an immediate invocation
        v = (v & ~mask) | ((id << extract_shift(mask)) & mask);
                                  ^
/__w/traccc/traccc/build/_deps/detray-src/core/include/detray/utils/bit_encoder.hpp:65:26: note: declared here
    static consteval int extract_shift(value_t mask) noexcept {
```                         ^

@stephenswat
Copy link
Member

Given that we have exactly zero (0) useful HIP code, we should probably just drop support for it at this point rather than spending valuable developer time on it, to be honest.

@beomki-yeo beomki-yeo force-pushed the update-to-detray-v77 branch from c09f007 to c124c88 Compare October 3, 2024 19:52
Copy link

sonarqubecloud bot commented Oct 3, 2024

@beomki-yeo beomki-yeo changed the title Update detray to v0.77.0 Update detray to v0.78.0 Oct 3, 2024
@beomki-yeo
Copy link
Contributor Author

The detray version is changed to v78.

There was an error in event_map2 test (occurred from v77) which I don't understand pretty well. Given that the used event file in /data/detray_simulation is too old to be used and the event_map2 will be replaced in the near future, I decided to remove the test

@beomki-yeo beomki-yeo merged commit 0b03d3f into acts-project:main Oct 3, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants