Not using detector description for partial chain examples #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beomki-yeo
force-pushed
the
not-use-dd-for-partial-chains
branch
from
9b54ab4 to
8a2abbb
Compare
krasznaa
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
I believe this is correct. In these cases the CSV reading code only needs traccc::silicon_detector_description to set the "module index" correctly on the spacepoints, measurements, etc. But none of these executables need "module index" to be set to a valid value anyway. 🤔
|
Yeah I also tried to find which algorithms use |
beomki-yeo
force-pushed
the
not-use-dd-for-partial-chains
branch
from
8a2abbb to
0535c4b
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the examples of partial chains make an error when the geometry json and digitizatoin config json are pointing to different geometry.
Problem is some geometries (e.g. ITk) that we are using do not have digitization config yet so it will always clash with the default one from TML detector.
This PR disables reading the digitization config file, which is not used in the algorithm anyway.