Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not using detector description for partial chain examples #726

Merged

Conversation

beomki-yeo
Copy link
Contributor

Currently, the examples of partial chains make an error when the geometry json and digitizatoin config json are pointing to different geometry.

Problem is some geometries (e.g. ITk) that we are using do not have digitization config yet so it will always clash with the default one from TML detector.

This PR disables reading the digitization config file, which is not used in the algorithm anyway.

@beomki-yeo beomki-yeo requested a review from krasznaa October 3, 2024 12:46
@beomki-yeo beomki-yeo force-pushed the not-use-dd-for-partial-chains branch from 9b54ab4 to 8a2abbb Compare October 3, 2024 12:49
Copy link
Member

@krasznaa krasznaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is correct. In these cases the CSV reading code only needs traccc::silicon_detector_description to set the "module index" correctly on the spacepoints, measurements, etc. But none of these executables need "module index" to be set to a valid value anyway. 🤔

@beomki-yeo
Copy link
Contributor Author

Yeah I also tried to find which algorithms use module_link after the clusterization, but it seems none of them do :p

@beomki-yeo beomki-yeo force-pushed the not-use-dd-for-partial-chains branch from 8a2abbb to 0535c4b Compare October 3, 2024 13:58
Copy link

sonarqubecloud bot commented Oct 3, 2024

@beomki-yeo beomki-yeo merged commit 397da59 into acts-project:main Oct 3, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants