Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply spacepoint formation to the 2D pixel detector only #727

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

beomki-yeo
Copy link
Contributor

To avoid the repeat the condition of if (meas.meas_dim == 2u) in host and device code, I changed the function of create_spacepoint to fill_spacepoint

@beomki-yeo beomki-yeo requested a review from krasznaa October 5, 2024 21:43
Copy link
Member

@stephenswat stephenswat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but let's not unnecessarily complicate the templating.

Copy link
Member

@krasznaa krasznaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the same time I don't feel super strongly about this point. Not enough to veto either of your proposals...

@beomki-yeo beomki-yeo force-pushed the sp-formation-only-for-2d branch from c81ce95 to 2026367 Compare October 7, 2024 11:47
@beomki-yeo beomki-yeo added the bug Something isn't working label Oct 8, 2024
Copy link

sonarqubecloud bot commented Oct 8, 2024

Copy link
Member

@krasznaa krasznaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

When doing the SoA migration, I can imagine adding some additional assertions here and there, but this is good with me as-is.

@beomki-yeo beomki-yeo merged commit ce1b363 into acts-project:main Oct 9, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants