Restructure device CKF for readability #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenswat
added
refactor
beomki-yeo
approved these changes
Oct 7, 2024
krasznaa
requested changes
Oct 7, 2024
There was a problem hiding this comment.
After every new vecmem buffer, you should always call vecmem::copy::setup(...)->ignore()! For non-resizable 1D buffers this is not technically not necessary, but it would help my OCD if we finally started doing this consistently. 🤔
Generally on board with the PR of course.
stephenswat
force-pushed
the
refactor/ckf_cleanup
branch
from
f0e06f0 to
4b94831
Compare
|
|
Updated. 👍 |
This commit doesn't change the CKF much functionally, but improves its readability a bit by moving variables closer to where they are used, and by adding smaller scopes. Also increases the clarity of the double buffering solution. May decrease memory consumption slightly as it encourages the compiler to free memory earlier.
|
I think @krasznaa would be OK now, so let me merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit doesn't change the CKF much functionally, but improves its readability a bit by moving variables closer to where they are used, and by adding smaller scopes. Also increases the clarity of the double buffering solution.
May decrease memory consumption slightly as it encourages the compiler to free memory earlier.