Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure device CKF for readability #728

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

stephenswat
Copy link
Member

This commit doesn't change the CKF much functionally, but improves its readability a bit by moving variables closer to where they are used, and by adding smaller scopes. Also increases the clarity of the double buffering solution.

May decrease memory consumption slightly as it encourages the compiler to free memory earlier.

@stephenswat stephenswat added refactor Change the structure of the code cuda Changes related to CUDA labels Oct 7, 2024
Copy link
Contributor

@beomki-yeo beomki-yeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just a couple of questions

Copy link
Member

@krasznaa krasznaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After every new vecmem buffer, you should always call vecmem::copy::setup(...)->ignore()! For non-resizable 1D buffers this is not technically not necessary, but it would help my OCD if we finally started doing this consistently. 🤔

Generally on board with the PR of course.

@stephenswat stephenswat force-pushed the refactor/ckf_cleanup branch from f0e06f0 to 4b94831 Compare October 7, 2024 11:45
Copy link

sonarqubecloud bot commented Oct 7, 2024

@stephenswat
Copy link
Member Author

Updated. 👍

This commit doesn't change the CKF much functionally, but improves its
readability a bit by moving variables closer to where they are used, and
by adding smaller scopes. Also increases the clarity of the double
buffering solution.

May decrease memory consumption slightly as it encourages the compiler
to free memory earlier.
@beomki-yeo
Copy link
Contributor

I think @krasznaa would be OK now, so let me merge it

@beomki-yeo beomki-yeo merged commit 35706ff into acts-project:main Oct 7, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda Changes related to CUDA refactor Change the structure of the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants