-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure device CKF for readability #728
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Just a couple of questions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After every new vecmem buffer, you should always call vecmem::copy::setup(...)->ignore()
! For non-resizable 1D buffers this is not technically not necessary, but it would help my OCD if we finally started doing this consistently. 🤔
Generally on board with the PR of course.
f0e06f0
to
4b94831
Compare
|
Updated. 👍 |
This commit doesn't change the CKF much functionally, but improves its readability a bit by moving variables closer to where they are used, and by adding smaller scopes. Also increases the clarity of the double buffering solution. May decrease memory consumption slightly as it encourages the compiler to free memory earlier.
I think @krasznaa would be OK now, so let me merge it |
This commit doesn't change the CKF much functionally, but improves its readability a bit by moving variables closer to where they are used, and by adding smaller scopes. Also increases the clarity of the double buffering solution.
May decrease memory consumption slightly as it encourages the compiler to free memory earlier.