-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use surface link for module projection #729
Conversation
Actually |
@stephenswat Any thought? |
I believe this is fine. But this PR by itself is really meaningless in my mind. For this to be meaningful, you should:
Could you add the first 2 points to this PR as well? |
01757a4
to
8cf4013
Compare
OK I removed the module link of measurements |
8cf4013
to
1e927f7
Compare
|
@krasznaa Could you review the PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I think module links do not have to be used after clusterization. This also helps the currect refactoring of #692