Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use surface link for module projection #729

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Use surface link for module projection #729

merged 2 commits into from
Oct 14, 2024

Conversation

beomki-yeo
Copy link
Contributor

I think module links do not have to be used after clusterization. This also helps the currect refactoring of #692

@beomki-yeo beomki-yeo requested a review from stephenswat October 7, 2024 11:15
@beomki-yeo
Copy link
Contributor Author

Actually module_link can be dropped from the measurement as it is not used anywhere but some tests - this will be followed up later

@beomki-yeo
Copy link
Contributor Author

@stephenswat Any thought?

@krasznaa
Copy link
Member

krasznaa commented Oct 9, 2024

I believe this is fine. But this PR by itself is really meaningless in my mind. For this to be meaningful, you should:

  • Remove the now unnecessary variable;
  • Remove the code that fills that unnecessary variable;
  • Do this change, which I believe is the last remaining client for this variable.

Could you add the first 2 points to this PR as well?

@beomki-yeo beomki-yeo force-pushed the use-surface-link branch 2 times, most recently from 01757a4 to 8cf4013 Compare October 9, 2024 15:00
@beomki-yeo
Copy link
Contributor Author

OK I removed the module link of measurements

@beomki-yeo beomki-yeo requested a review from krasznaa October 9, 2024 15:01
@beomki-yeo beomki-yeo mentioned this pull request Oct 10, 2024
Merged
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
26.7% Duplication on New Code

See analysis details on SonarCloud

@beomki-yeo
Copy link
Contributor Author

@krasznaa Could you review the PR?

krasznaa
krasznaa approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@krasznaa krasznaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@beomki-yeo beomki-yeo merged commit 1d7ca74 into acts-project:main Oct 14, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krasznaa krasznaa krasznaa approved these changes

@stephenswat stephenswat Awaiting requested review from stephenswat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beomki-yeo @krasznaa