Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the seeding and finding performance #735

Merged
merged 4 commits into from
Oct 10, 2024

Conversation

beomki-yeo
Copy link
Contributor

@beomki-yeo beomki-yeo commented Oct 8, 2024

The efficiency drop is from bad seeding config (which was optimized for tml detector) and loose particle selection in performance writers. I also synchronized the truth cut for seeding and finding performance writer

After fixing them, good efficiency is obtained for single muon ODD events

./bin/traccc_seq_example --digitization-file=geometries/odd/odd-digi-geometric-config.json --detector-file=geometries/odd_full/odd-detray_geometry_detray.json --grid-file=geometries/odd_full/odd-detray_surface_grids_detray.json --material-file=geometries/odd_full/odd-detray_material_detray.json --use-detray-detector --use-acts-geom-source --input-directory=odd/geant4_10muon_100GeV/ --input-events=100 --check-performance

image

@beomki-yeo beomki-yeo marked this pull request as draft October 8, 2024 23:09
@beomki-yeo beomki-yeo force-pushed the improve-efficiency branch 2 times, most recently from 6c73cd5 to 87d1d63 Compare October 9, 2024 00:02
@beomki-yeo beomki-yeo marked this pull request as ready for review October 9, 2024 01:05
@beomki-yeo beomki-yeo requested review from krasznaa and stephenswat and removed request for krasznaa October 9, 2024 01:05
@beomki-yeo beomki-yeo changed the title Improve the seeding performance Improve the seeding and finding performance Oct 9, 2024
@beomki-yeo
Copy link
Contributor Author

I set the r and z range of particle selection to cover the pixel barrel of ODD by default:

image

Copy link
Contributor

@asalzburger asalzburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes a lot of sense, the adapted range sound reasonable, and also the increase on the scattering parameter should happen ODD has way more material than TrackML.

@stephenswat stephenswat enabled auto-merge (squash) October 10, 2024 10:06
Copy link

@stephenswat stephenswat merged commit 9a34aeb into acts-project:main Oct 10, 2024
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants