-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap the phi of track parameters in the range of [-pi,pi] #736
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would've been nicer to make this into member code inside of detray::bound_track_parameters
, but I guess this is the next best thing. 🤔
I think this PR is using |
Co-authored-by: Joana Niermann <53186085+niermann999@users.noreply.github.com>
|
This is for constraining the values of phi from Kalman updater and smoother to be within [-pi,pi].
If we don't do this, very occasionally, the while loop of
wrap_to_pi
ofis_same_angle
can take very long time.