Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap the phi of track parameters in the range of [-pi,pi] #736

Merged
merged 4 commits into from
Oct 14, 2024

Conversation

beomki-yeo
Copy link
Contributor

@beomki-yeo beomki-yeo commented Oct 13, 2024

This is for constraining the values of phi from Kalman updater and smoother to be within [-pi,pi].
If we don't do this, very occasionally, the while loop of wrap_to_pi of is_same_angle can take very long time.

@beomki-yeo beomki-yeo requested a review from krasznaa October 14, 2024 09:44
Copy link
Member

@krasznaa krasznaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would've been nicer to make this into member code inside of detray::bound_track_parameters, but I guess this is the next best thing. 🤔

@stephenswat
Copy link
Member

stephenswat commented Oct 14, 2024 via email

@beomki-yeo
Copy link
Contributor Author

I think this PR is using fmod

Co-authored-by: Joana Niermann <53186085+niermann999@users.noreply.github.com>
Copy link

@beomki-yeo beomki-yeo merged commit 55f8dc3 into acts-project:main Oct 14, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants