Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Update to detray version 0.79.0 and algebra-plugins version 0.25.0 #737

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

niermann999
Copy link
Contributor

Mostly addressing maintainability issues in detray:

  • Rename vc to vc_aos
  • Remove enable_if
  • Use ranges algorithms
  • Refactor type traits into concepts
  • Split dependency between benchmarks and svgtools and make validation utils lib

@niermann999 niermann999 added the refactor Change the structure of the code label Oct 14, 2024
@stephenswat
Copy link
Member

@niermann999
Copy link
Contributor Author

Gentle nudge 👼

https://github.com/acts-project/detray/blob/main/CMakeLists.txt#L9

Thanks! Absolutely forgot about that again. Is there maybe a way to automatize this?

@krasznaa
Copy link
Member

Gentle nudge 👼
https://github.com/acts-project/detray/blob/main/CMakeLists.txt#L9

Thanks! Absolutely forgot about that again. Is there maybe a way to automatize this?

No real "automation" that I would be aware of. 😦 The only thing that can be automated is to create TGZ source files with the correct version number automatically. But then the version number in git would never be reliable. 🤔 So remembering to update the version after every tag is pretty much the simplest thing that we can do in my mind.

@stephenswat
Copy link
Member

I was hoping there would be a pre-tag Git hook, but nope: https://git-scm.com/docs/githooks

@stephenswat stephenswat enabled auto-merge (squash) October 15, 2024 18:07
Copy link

@stephenswat stephenswat merged commit 4c26db6 into acts-project:main Oct 15, 2024
19 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Change the structure of the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants