Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip the time component calculation in track param estimation #738

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

beomki-yeo
Copy link
Contributor

@beomki-yeo beomki-yeo commented Oct 15, 2024

The motivation is the time component becomes inf very occasionally in the case of invTanTheta=0 or vz=0. And This fails CKF making all other parameters nan values.

I could come up with some ideas to avoid this inifinite values but I decided to remove all the relevant codes because this does not seem to be very useful. Also ACTS takes an actual measured time instead of analytically calculated one:
https://github.com/acts-project/acts/blob/fb3ddf48fdcf2bc08052e0a925a0c0531fa056f8/Core/include/Acts/Seeding/EstimateTrackParamsFromSeed.hpp#L272

Copy link
Member

@krasznaa krasznaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks sane... 🤔

I'll refer to your judgement on this.

Copy link

@beomki-yeo beomki-yeo merged commit 068f7a9 into acts-project:main Oct 15, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants