Skip the time component calculation in track param estimation #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krasznaa
approved these changes
Oct 15, 2024
beomki-yeo
force-pushed
the
clear-time
branch
from
8be2c8e to
848554b
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation is the time component becomes
infvery occasionally in the case ofinvTanTheta=0orvz=0. And This fails CKF making all other parametersnanvalues.I could come up with some ideas to avoid this inifinite values but I decided to remove all the relevant codes because this does not seem to be very useful. Also ACTS takes an actual measured time instead of analytically calculated one:
https://github.com/acts-project/acts/blob/fb3ddf48fdcf2bc08052e0a925a0c0531fa056f8/Core/include/Acts/Seeding/EstimateTrackParamsFromSeed.hpp#L272