Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the default value of chi2 max to 10 #743

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Change the default value of chi2 max to 10 #743

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63d405e
Change the default value of chi2 max to 10
beomki-yeo Oct 17, 2024
f150137
Merge branch 'main' into change-chi2
beomki-yeo Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/include/traccc/finding/finding_config.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ struct finding_config {
unsigned int max_step_counts_for_next_surface = 100;

/// Maximum Chi-square that is allowed for branching
float chi2_max = 30.f;
float chi2_max = 10.f;

/// Propagation configuration
detray::propagation::config propagation{};
Expand Down
2 changes: 1 addition & 1 deletion examples/options/include/traccc/options/track_finding.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ class track_finding : public interface, public config_provider<finding_config> {
/// Maximum step counts that track can make to reach the next surface
unsigned int max_step_counts_for_next_surface = 100;
/// Maximum chi2 for a measurement to be included in the track
float chi2_max = 30.f;
float chi2_max = 10.f;
/// Maximum number of branches which each initial seed can have at a step
unsigned int nmax_per_seed = 10;
/// Maximum allowed number of skipped steps per candidate
Expand Down
2 changes: 2 additions & 0 deletions tests/cpu/test_ckf_combinatorics_telescope.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,10 +115,12 @@ TEST_P(CpuCkfCombinatoricsTelescopeTests, Run) {
rk_stepper_type, host_navigator_type>::config_type cfg_no_limit;
cfg_no_limit.max_num_branches_per_seed =
std::numeric_limits<unsigned int>::max();
cfg_no_limit.chi2_max = 30.f;

typename traccc::finding_algorithm<
rk_stepper_type, host_navigator_type>::config_type cfg_limit;
cfg_limit.max_num_branches_per_seed = 500;
cfg_limit.chi2_max = 30.f;

// Finding algorithm object
traccc::finding_algorithm<rk_stepper_type, host_navigator_type>
Expand Down
1 change: 1 addition & 0 deletions tests/cpu/test_ckf_sparse_tracks_telescope.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ TEST_P(CkfSparseTrackTelescopeTests, Run) {
typename traccc::finding_algorithm<rk_stepper_type,
host_navigator_type>::config_type cfg;
cfg.ptc_hypothesis = ptc;
cfg.chi2_max = 30.f;

// Finding algorithm object
traccc::finding_algorithm<rk_stepper_type, host_navigator_type>
Expand Down
2 changes: 2 additions & 0 deletions tests/cuda/test_ckf_combinatorics_telescope.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,11 +139,13 @@ TEST_P(CudaCkfCombinatoricsTelescopeTests, Run) {
rk_stepper_type, device_navigator_type>::config_type cfg_no_limit;
cfg_no_limit.ptc_hypothesis = ptc;
cfg_no_limit.max_num_branches_per_seed = 100000;
cfg_no_limit.chi2_max = 30.f;

typename traccc::cuda::finding_algorithm<
rk_stepper_type, device_navigator_type>::config_type cfg_limit;
cfg_limit.ptc_hypothesis = ptc;
cfg_limit.max_num_branches_per_seed = 500;
cfg_limit.chi2_max = 30.f;

// Finding algorithm object
traccc::cuda::finding_algorithm<rk_stepper_type, device_navigator_type>
Expand Down
2 changes: 1 addition & 1 deletion tests/cuda/test_ckf_toy_detector.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ TEST_P(CkfToyDetectorTests, Run) {
rk_stepper_type, device_navigator_type>::config_type cfg;
cfg.ptc_hypothesis = ptc;
cfg.max_num_branches_per_seed = 500;

cfg.chi2_max = 30.f;
cfg.propagation.navigation.search_window = search_window;

// Finding algorithm object
Expand Down
Loading