-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Double matching condition for track finding effieicny #745
Conversation
This is the final PR before creating the tag... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Way to scare be in the home stretch... 😟
|
The recovery at eta~0 makes sense: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine. Let's make the tag finally.
Based on #692
Double matching condition:
We have been only using the first condition. This PR adds the second one.
Relevant ACTS code can be found here: https://github.com/acts-project/acts/blob/f935e2512cc72577eb9aa9934a6f7b52f4c0dd53/Examples/Algorithms/TruthTracking/ActsExamples/TruthTracking/TrackTruthMatcher.cpp#L105
As expected, the efficiency drops but not so much
Before
After