Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double matching condition for track finding effieicny #745

Merged
merged 12 commits into from
Oct 18, 2024

Conversation

beomki-yeo
Copy link
Contributor

Based on #692

Double matching condition:

  1. The number of measurements from the major particle is larger than a half of the number of the measurements of the found track
  2. The number of measurements from the major particle is larger than a half of the number of measurements produced by the particle

We have been only using the first condition. This PR adds the second one.

Relevant ACTS code can be found here: https://github.com/acts-project/acts/blob/f935e2512cc72577eb9aa9934a6f7b52f4c0dd53/Examples/Algorithms/TruthTracking/ActsExamples/TruthTracking/TrackTruthMatcher.cpp#L105

As expected, the efficiency drops but not so much

Before

After

@beomki-yeo beomki-yeo requested a review from krasznaa October 18, 2024 12:06
@beomki-yeo
Copy link
Contributor Author

This is the final PR before creating the tag...

Copy link
Member

@krasznaa krasznaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Way to scare be in the home stretch... 😟

Copy link

@beomki-yeo
Copy link
Contributor Author

beomki-yeo commented Oct 18, 2024

The plot gets more sense now...

single muon events

Before with the bug in division
image

After fixing the bug
image

@beomki-yeo beomki-yeo requested a review from krasznaa October 18, 2024 12:46
@beomki-yeo
Copy link
Contributor Author

The recovery at eta~0 makes sense:
As the track is orthogonal to the module, the cluster size (# number of cells) are usually small so the hit count sum frequently gets smaller than the measurements size which makes the value of division zero

Copy link
Member

@krasznaa krasznaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine. Let's make the tag finally.

@krasznaa krasznaa merged commit 4401cc9 into acts-project:main Oct 18, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants