Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable -Wconversion #746

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

stephenswat
Copy link
Member

@stephenswat stephenswat commented Oct 18, 2024

This commit replaces the existing Wfloat-conversion flag with the more strict -Wconversion and fixes related errors. These were mostly harmless integer conversions, but certainly also some nasty improper floating point-to-integer conversions which may constitute bugs.

@stephenswat
Copy link
Member Author

False positives from Sonarcloud.

@stephenswat stephenswat force-pushed the build/enable_Wconversion branch 8 times, most recently from 095b81c to 716ce87 Compare October 22, 2024 08:50
@stephenswat stephenswat added the build This relates to the build system label Oct 22, 2024
@stephenswat
Copy link
Member Author

Finally passed the tests. @krasznaa

@stephenswat stephenswat force-pushed the build/enable_Wconversion branch from 716ce87 to 60af5af Compare October 23, 2024 08:55
Copy link
Contributor

@beomki-yeo beomki-yeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this first

@stephenswat stephenswat force-pushed the build/enable_Wconversion branch from 60af5af to 4d85767 Compare October 23, 2024 09:17
Copy link

This commit replaces the existing `Wfloat-conversion` flag with the more
strict `-Wconversion` and fixes related errors. These were mostly
harmless integer conversions, but certainly also some nasty improper
floating point-to-integer conversions which may constitute bugs.
@stephenswat stephenswat enabled auto-merge October 23, 2024 09:28
@stephenswat stephenswat merged commit c627770 into acts-project:main Oct 23, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build This relates to the build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants