Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-Template Spacepoint Formation, main branch (2024.10.23.) #749

Conversation

krasznaa
Copy link
Member

Following the example of #722, here I remove the "class level templating" from the host implementation of the spacepoint formation algorithm.

Beside all of the code re-organization, I also renamed the algorithm to a much more descriptive name (traccc::host::silicon_pixel_spacepoint_formation_algorithm). To make it very clear what it's meant to be able to do. Later when/if we introduce spacepoint formation from strip measurements, we can choose to either add a separate algorithm for that, or to make this one smarter, while also renaming it. 🤔

@krasznaa krasznaa added the cpu Changes related to CPU code label Oct 23, 2024
Renamed the algorithm to traccc::host::silicon_pixel_spacepoint_formation_algorithm,
to make it very clear what the algorithm is doing. Once we introduce logic
for creating spacepoints off of silicon strip measurements, we can see
what to do. (Rename this algorithm, or add a separate algorithm that does
the strip spacepoint creation.)
@krasznaa krasznaa force-pushed the DeTemplateSpacepointFormation-main-20241023 branch from c63b727 to 9077bbc Compare October 23, 2024 15:48
Copy link

Copy link
Member

@stephenswat stephenswat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

@stephenswat stephenswat merged commit 7bf2c1b into acts-project:main Oct 24, 2024
23 checks passed
@beomki-yeo
Copy link
Contributor

Let's do things one-by-one - Please don't rename the spacepoint_formation to silicon_pixel_spacepoint_formation in this PR.

@beomki-yeo
Copy link
Contributor

Wth

stephenswat added a commit that referenced this pull request Oct 24, 2024
@stephenswat
Copy link
Member

Wth

Sorry; we can revert if you would like to have the name changed back

@beomki-yeo
Copy link
Contributor

Yeah please do so. I think there is no advantage in differentiating this algorithm to different data types.

In case we want to this, we will need to put a set of pixel measurements only to the silicon_pixel_spacepoint_formation. Current approach seems to be error-prone

@krasznaa krasznaa deleted the DeTemplateSpacepointFormation-main-20241023 branch October 30, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpu Changes related to CPU code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants