-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
De-Template Spacepoint Formation, main branch (2024.10.23.) #749
De-Template Spacepoint Formation, main branch (2024.10.23.) #749
Conversation
Renamed the algorithm to traccc::host::silicon_pixel_spacepoint_formation_algorithm, to make it very clear what the algorithm is doing. Once we introduce logic for creating spacepoints off of silicon strip measurements, we can see what to do. (Rename this algorithm, or add a separate algorithm that does the strip spacepoint creation.)
c63b727
to
9077bbc
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.
Let's do things one-by-one - Please don't rename the |
Wth |
Sorry; we can revert if you would like to have the name changed back |
Yeah please do so. I think there is no advantage in differentiating this algorithm to different data types. In case we want to this, we will need to put a set of pixel measurements only to the |
Following the example of #722, here I remove the "class level templating" from the host implementation of the spacepoint formation algorithm.
Beside all of the code re-organization, I also renamed the algorithm to a much more descriptive name (
traccc::host::silicon_pixel_spacepoint_formation_algorithm
). To make it very clear what it's meant to be able to do. Later when/if we introduce spacepoint formation from strip measurements, we can choose to either add a separate algorithm for that, or to make this one smarter, while also renaming it. 🤔