De-Template Spacepoint Formation, main branch (2024.10.23.) #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed the algorithm to traccc::host::silicon_pixel_spacepoint_formation_algorithm, to make it very clear what the algorithm is doing. Once we introduce logic for creating spacepoints off of silicon strip measurements, we can see what to do. (Rename this algorithm, or add a separate algorithm that does the strip spacepoint creation.)
krasznaa
force-pushed
the
DeTemplateSpacepointFormation-main-20241023
branch
from
c63b727 to
9077bbc
Compare
|
|
Let's do things one-by-one - Please don't rename the |
|
Wth |
Sorry; we can revert if you would like to have the name changed back |
|
Yeah please do so. I think there is no advantage in differentiating this algorithm to different data types. In case we want to this, we will need to put a set of pixel measurements only to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the example of #722, here I remove the "class level templating" from the host implementation of the spacepoint formation algorithm.
Beside all of the code re-organization, I also renamed the algorithm to a much more descriptive name (
traccc::host::silicon_pixel_spacepoint_formation_algorithm). To make it very clear what it's meant to be able to do. Later when/if we introduce spacepoint formation from strip measurements, we can choose to either add a separate algorithm for that, or to make this one smarter, while also renaming it. 🤔