-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add theta range input #752
Conversation
🤔 How about going something like this? https://www.boost.org/doc/libs/1_86_0/libs/program_options/example/real.cpp I.e. define both As far as I could find with a quick search, there's no built-in functionality in |
yes, we do smth like that also in detray : https://github.com/acts-project/detray/blob/a05a161a063b2ae4d71e408424c052f0d679a42d/tests/tools/include/detray/options/track_generator_options.hpp#L137 |
I followed the example code provided by @krasznaa . @niermann999 's sugesstion sounds reasonable but let's do this in the next PRs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm very on board with this, just let's see about these technicalities first. 😉
ae11d03
to
284483e
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was a bit hesitant about the public dependency at first, but in the end this is part of the "example code". Having traccc::options
publicly depend on traccc::performance
is not actually a big deal. And keeping the private dependency would make the code a whole lot uglier. 🤔
So yeah, let's just go with this! 👍
This PR allows to set a theta range input instead of eta when
use-theta-range-input
is ON.Currently this is the best I could come up with but I wonder if we can block the set of
theta-range
whenuse-theta-range-input
is OFF.