Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add theta range input #752

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Add theta range input #752

merged 2 commits into from
Oct 28, 2024

Conversation

beomki-yeo
Copy link
Contributor

This PR allows to set a theta range input instead of eta when use-theta-range-input is ON.

Currently this is the best I could come up with but I wonder if we can block the set of theta-range when use-theta-range-input is OFF.

@krasznaa
Copy link
Member

🤔 How about going something like this?

https://www.boost.org/doc/libs/1_86_0/libs/program_options/example/real.cpp

I.e. define both --gen-eta and --gen-theta, and throw an error if the user specified both. (With a help message explaining this behaviour.)

As far as I could find with a quick search, there's no built-in functionality in boost::program_options for expressing this relationship between two options. But we can put in an if(...) statement ourselves for this. 🤔

@niermann999
Copy link
Contributor

@beomki-yeo
Copy link
Contributor Author

I followed the example code provided by @krasznaa . @niermann999 's sugesstion sounds reasonable but let's do this in the next PRs

Copy link
Member

@krasznaa krasznaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm very on board with this, just let's see about these technicalities first. 😉

Copy link

Copy link
Member

@krasznaa krasznaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was a bit hesitant about the public dependency at first, but in the end this is part of the "example code". Having traccc::options publicly depend on traccc::performance is not actually a big deal. And keeping the private dependency would make the code a whole lot uglier. 🤔

So yeah, let's just go with this! 👍

@beomki-yeo beomki-yeo merged commit 05279ac into acts-project:main Oct 28, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants