Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake Updates, main branch (2024.11.09.) #766

Merged
merged 4 commits into from
Nov 12, 2024
Merged

CMake Updates, main branch (2024.11.09.) #766

merged 4 commits into from
Nov 12, 2024

Conversation

krasznaa
Copy link
Member

@krasznaa krasznaa commented Nov 9, 2024

This is to try to remove some pesky CMake warnings that have showed up with modern CMake versions over some period of time. The goal is that this PR + #765 would allow us to configure the build of the project without any warnings with CMake 3.30.X.

Things done:

  • I disabled the build of Vc. We've not been using it for anything really in this project so far. We'll be able to re-enable it once needed, but until then this gets rid of all the warnings from its old CMake code.
  • Switched to finding Boost using its own CMake code. (See: CMP0167)
  • Stopped using FetchContent_Populate with GoogleTest. (See: CMP0169)
    • The original reason for doing this is void by now anyway... (It's a longer story.)
  • Stopped installing GoogleBenhmark together with the project. At the same time turned its libraries into static ones, since when we install benchmark executables, they should still remain usable. (Without creating possible conflicts with other installed GoogleBenchmark installations.)

@krasznaa krasznaa added the build This relates to the build system label Nov 9, 2024
@krasznaa krasznaa force-pushed the CMakeUpdates-main-20241108 branch from 13ed3db to 84ca75d Compare November 11, 2024 10:37
stephenswat
stephenswat approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@stephenswat stephenswat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. 👍

@krasznaa
Turn off the build of Vc by default.
34b824d 
The Vc backend of Detray and algebra-plugins is not used
in this project at all at the moment. So don't build the
warning-full code by default.
@krasznaa
Switch to using Boost's own CMake code.
ae5cddf 
Starting with CMake 3.30 it triggers a warning to try to use
FindBoost.cmake.
@krasznaa
Switched to FetchContent_MakeAvailable(...).
3aa4f29 
Since the setup was already only building things that
we need from GoogleTest. This gets rid of a warning with
modern CMake versions.
@krasznaa
Disabled the install of GoogleBenchmark.
106c817 
Since benchmarking executables are themselves installed, also
made the build produce static libraries for the project.
@krasznaa krasznaa force-pushed the CMakeUpdates-main-20241108 branch from 84ca75d to 106c817 Compare November 12, 2024 12:22
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@stephenswat stephenswat merged commit 20e6a09 into acts-project:main Nov 12, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulgessinger paulgessinger paulgessinger left review comments

@stephenswat stephenswat stephenswat approved these changes

@beomki-yeo beomki-yeo Awaiting requested review from beomki-yeo

Assignees
No one assigned
Labels
build This relates to the build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krasznaa @paulgessinger @stephenswat