Update Host Track Finding, main branch (2024.11.11.) #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Giving the class and file names longer, hopefully more expressive names.
Allowing clients to use it with specializations not included in traccc::core.
krasznaa
force-pushed
the
UpdateHostTrackFinding-main-20241111
branch
from
a63be64 to
e0e560b
Compare
|
SonarCloud is correct that range based algorithms would be nice to use in the host code. But for that we'll first need to make vecmem device containers work correctly with those algorithms... 🤔 Because it seems that they don't. (But I also didn't investigate too deeply at this point.) |
|
beomki-yeo
approved these changes
Nov 11, 2024
flg
pushed a commit
to flg/traccc
that referenced
this pull request
Nov 26, 2024
* Renamed the host CKF algorithm. Giving the class and file names longer, hopefully more expressive names. * Made the templated track finding function public. Allowing clients to use it with specializations not included in traccc::core.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to update the host track finding algorithm to be more in line with #756.
traccc::host::ckf_algorithmintotraccc::host::combinatorial_kalman_filter_algorithm, and made the "specialization source file" names a little longer / more elaborate as well.traccc::host::details::find_tracksto be publicly visible intraccc::core. So that clients could use it directly, in case they want to use a detector / stepper / navigator that we don't support at the moment.