Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Host Track Finding, main branch (2024.11.11.) #768

Merged

Conversation

krasznaa
Copy link
Member

This is to update the host track finding algorithm to be more in line with #756.

  • I renamed traccc::host::ckf_algorithm into traccc::host::combinatorial_kalman_filter_algorithm, and made the "specialization source file" names a little longer / more elaborate as well.
  • I moved traccc::host::details::find_tracks to be publicly visible in traccc::core. So that clients could use it directly, in case they want to use a detector / stepper / navigator that we don't support at the moment.

@krasznaa krasznaa added the cpu Changes related to CPU code label Nov 11, 2024
Giving the class and file names longer, hopefully more
expressive names.
Allowing clients to use it with specializations not included
in traccc::core.
@krasznaa krasznaa force-pushed the UpdateHostTrackFinding-main-20241111 branch from a63be64 to e0e560b Compare November 11, 2024 13:45
@krasznaa
Copy link
Member Author

SonarCloud is correct that range based algorithms would be nice to use in the host code. But for that we'll first need to make vecmem device containers work correctly with those algorithms... 🤔 Because it seems that they don't. (But I also didn't investigate too deeply at this point.)

Copy link

Copy link
Contributor

@beomki-yeo beomki-yeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

combinatorial_kalman_filter_algorithm seems quite long but it is probably better than ckf_algorithm 🤔

@krasznaa krasznaa merged commit df652bf into acts-project:main Nov 11, 2024
26 checks passed
@krasznaa krasznaa deleted the UpdateHostTrackFinding-main-20241111 branch November 11, 2024 15:32
flg pushed a commit to flg/traccc that referenced this pull request Nov 26, 2024
* Renamed the host CKF algorithm.

Giving the class and file names longer, hopefully more
expressive names.

* Made the templated track finding function public.

Allowing clients to use it with specializations not included
in traccc::core.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpu Changes related to CPU code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants