Refactor the Parameter interface for Kalman fitting test #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Be careful to either move the track generator origin into the detector space or set |
beomki-yeo
commented
Nov 15, 2024
| detray::tel_det_config<> tel_cfg{rectangle}; | ||
| tel_cfg.positions(plane_positions); | ||
| tel_cfg.module_material(mat); | ||
| tel_cfg.mat_thickness(thickness); | ||
| tel_cfg.pilot_track(traj); | ||
| tel_cfg.envelope(offset * 2.f); |
There was a problem hiding this comment.
I think this is good enough
|
Review anyone? |
beomki-yeo
force-pushed
the
refactor-kf-fixture
branch
from
a0223f1 to
bff78c7
Compare
krasznaa
reviewed
Nov 23, 2024
|
It's been a while since SYCL KF test was disabled. (See #655) Maybe there are more things to fix other than the change in this PR. So I suggest to do it with a dedicated PR |
krasznaa
approved these changes
Nov 24, 2024
|
flg
pushed a commit
to flg/traccc
that referenced
this pull request
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current
mainbranch, all tests derived fromKalmanFittingTestsshare the same input parameters.This made it impossible to give the input parameters specific to detector types (e.g. Telescope, toy geometry and wire chamber).
In this PR,
KalmanFittingTestsdoes not take input parameters anymore. Instead,KalmanFittingTelescopeTests,KalmanFittingToyDetectorTests, andKalmanFittingWireChamberTestshave their own input parameters.KalmanFittingTelescopeTestsalso sets the planes (20 mm, 40 mm, ..., 180 mm) instead of (0 mm, 20 mm, ..., 160 mm)