Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection Comparison Progress Bar, main branch (2024.11.27.) #786

Merged

Conversation

krasznaa
Copy link
Member

Added a progress bar for the collection comparisons.

For high object counts these comparisons can take a while. To give some feedback to the user about the progress of a comparison, added a progress bar that would provide this information. Now that we have access to such a thing. (#780)

And for why this is really necessary:

image

Hopefully this will help (at least in morals) with debugging the current ITk weirdnesses.

@krasznaa krasznaa added the performance Performance-relevant changes label Nov 27, 2024
@krasznaa
Copy link
Member Author

Unfortunately SonarCloud is completely missing the point of that code...

image

If I wanted to construct the data object in the class body, I wouldn't need to use PImpl in the first place...

Copy link
Member

@stephenswat stephenswat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed the SonarCloud warning is nonsense.

For high object counts these comparisons can take a while.
To give some feedback to the user about the progress of a
comparison, added a progress bar that would provide this
information.
@krasznaa krasznaa force-pushed the ComparisonProgress-main-20241127 branch from 841bacc to 8aa61e2 Compare November 27, 2024 10:50
Copy link

@krasznaa krasznaa merged commit 99a341e into acts-project:main Nov 27, 2024
26 checks passed
@krasznaa krasznaa deleted the ComparisonProgress-main-20241127 branch November 27, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance-relevant changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants