Collection Comparison Progress Bar, main branch (2024.11.27.) #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately SonarCloud is completely missing the point of that code...
If I wanted to construct the data object in the class body, I wouldn't need to use PImpl in the first place... |
stephenswat
approved these changes
Nov 27, 2024
For high object counts these comparisons can take a while. To give some feedback to the user about the progress of a comparison, added a progress bar that would provide this information.
krasznaa
force-pushed
the
ComparisonProgress-main-20241127
branch
from
841bacc to
8aa61e2
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a progress bar for the collection comparisons.
For high object counts these comparisons can take a while. To give some feedback to the user about the progress of a comparison, added a progress bar that would provide this information. Now that we have access to such a thing. (#780)
And for why this is really necessary:
Hopefully this will help (at least in morals) with debugging the current ITk weirdnesses.