Add an argument for B field in the Telescope KF test #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beomki-yeo
changed the title
krasznaa
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
I'm fine with this, but I wonder... Why not make the test completely generic at this point? Instead of passing in a single vector for generating a constant field with, why not instead pass in a Covfie object that may have any kind of field?
I'm not sure what the best formalism for that would be, but that's where @stephenswat would come in. 😉
But as I started, this is fine as-is for me.
|
Any kind of field including inhomogeneous ones? If I am correct, homogeneous and inhomogeneous ones are defined with different classes so maybe not an easy thing to implement 🤔 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perhaps I will also need this for #788