Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an argument for B field in the Telescope KF test #795

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

beomki-yeo
Copy link
Contributor

Perhaps I will also need this for #788

@beomki-yeo beomki-yeo changed the title Add an argument for magnetic field in the KF test Add an argument for B field in the Telescope KF test Dec 3, 2024
Copy link
Member

@krasznaa krasznaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this, but I wonder... Why not make the test completely generic at this point? Instead of passing in a single vector for generating a constant field with, why not instead pass in a Covfie object that may have any kind of field?

I'm not sure what the best formalism for that would be, but that's where @stephenswat would come in. 😉

But as I started, this is fine as-is for me.

@beomki-yeo
Copy link
Contributor Author

Any kind of field including inhomogeneous ones? If I am correct, homogeneous and inhomogeneous ones are defined with different classes so maybe not an easy thing to implement 🤔

Copy link

sonarqubecloud bot commented Dec 4, 2024

@beomki-yeo beomki-yeo merged commit fa8e018 into acts-project:main Dec 4, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants