Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CUDA, HIP and SYCL targets for Alpaka #797

Merged
merged 12 commits into from
Dec 16, 2024

Conversation

StewMH
Copy link
Contributor

@StewMH StewMH commented Dec 4, 2024

Seeing if we can test the build for all our Alpaka versions.

Copy link
Member

@krasznaa krasznaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image names don't seem correct at the moment. 🤔

@StewMH StewMH marked this pull request as ready for review December 11, 2024 22:22
@krasznaa
Copy link
Member

I'll have to think a bit about the warning that this PR uncovered... 🤔

/__w/traccc/traccc/core/include/traccc/geometry/silicon_detector_description.hpp(44): warning #20011-D: calling a __host__ function("vecmem::edm::details::host_type_at<T1,  ::vecmem::edm::type::vector< ::detray::geometry::barcode> ,  ::vecmem::edm::type::vector< ::algebra::generic::math::transform3<unsigned long, float,  ::algebra::array::matrix_type,     ::std::array> > ,  ::vecmem::edm::type::vector<unsigned long> ,  ::vecmem::edm::type::vector<float> ,  ::vecmem::edm::type::vector<float> ,  ::vecmem::edm::type::vector<float> ,  ::vecmem::edm::type::vector<float> ,  ::vecmem::edm::type::vector<float> ,  ::vecmem::edm::type::vector<unsigned char>  > ::return_type vecmem::edm::host< ::vecmem::edm::schema< ::vecmem::edm::type::vector< ::detray::geometry::barcode> ,  ::vecmem::edm::type::vector< ::algebra::generic::math::transform3<unsigned long, float,  ::algebra::array::matrix_type,     ::std::array> > ,  ::vecmem::edm::type::vector<unsigned long> ,  ::vecmem::edm::type::vector<float> ,  ::vecmem::edm::type::vector<float> ,  ::vecmem::edm::type::vector<float> ,  ::vecmem::edm::type::vector<float> ,  ::vecmem::edm::type::vector<float> ,  ::vecmem::edm::type::vector<unsigned char>  > ,  ::traccc::silicon_detector_description_interface> ::get<(unsigned long)0ul> ()") from a __host__ __device__ function("traccc::silicon_detector_description_interface< ::vecmem::edm::host< ::vecmem::edm::schema< ::vecmem::edm::type::vector< ::detray::geometry::barcode> ,  ::vecmem::edm::type::vector< ::algebra::generic::math::transform3<unsigned long, float,  ::algebra::array::matrix_type,     ::std::array> > ,  ::vecmem::edm::type::vector<unsigned long> ,  ::vecmem::edm::type::vector<float> ,  ::vecmem::edm::type::vector<float> ,  ::vecmem::edm::type::vector<float> ,  ::vecmem::edm::type::vector<float> ,  ::vecmem::edm::type::vector<float> ,  ::vecmem::edm::type::vector<unsigned char>  > , traccc::silicon_detector_description_interface> > ::geometry_id") is not allowed

Not sure yet how to best fix it in vecmem...

@StewMH
Copy link
Contributor Author

StewMH commented Dec 12, 2024

@krasznaa @stephenswat @beomki-yeo I think I've addressed everything. OK to merge soon?

@stephenswat stephenswat dismissed krasznaa’s stale review December 16, 2024 16:16

Changes addressed by Stewart.

@stephenswat stephenswat merged commit c06d483 into acts-project:main Dec 16, 2024
29 checks passed
@StewMH StewMH deleted the alpaka_ci branch December 16, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants