ref: Update to detray version 0.85.0 and adapt to new algebra-plugins API #798
+125
−156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niermann999
force-pushed
the
ref-update-detray
branch
3 times, most recently
from
dfedb51 to
2696614
Compare
niermann999
added
refactor
|
Just to make it obvious that this is still a draft, as it uses test/development versions of algebra-plugins and detray. |
The corresponding algebra-plugins tag is ready, as is the PR in detray (883) |
niermann999
force-pushed
the
ref-update-detray
branch
from
2696614 to
41b973c
Compare
|
But please rename the PR to something more meaningful before we merge |
niermann999
changed the title
krasznaa
requested changes
Dec 7, 2024
krasznaa
reviewed
Dec 8, 2024
niermann999
force-pushed
the
ref-update-detray
branch
2 times, most recently
from
213fec1 to
d725c17
Compare
niermann999
force-pushed
the
ref-update-detray
branch
from
d725c17 to
3971bb1
Compare
|
|
This PR seems to slow down the benchmark? |
|
That's curious. 🤔 |
This is strange indeed, since I was just now working on the detray benchmarks and I am not seeing the same problem... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test if the new algebra plugin integration works.
Edit: It turns out that algebra plugins has included the arithmetic operators for
std::arrayvector types in the global namespace from where they were picked up in the ACTS VectorHelper by Eigen types. The operators are now moved into the algebra namespace and from there imported into the detray and traccc namspaces.