-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: Update to detray version 0.85.0 and adapt to new algebra-plugins API #798
Conversation
dfedb51
to
2696614
Compare
Just to make it obvious that this is still a draft, as it uses test/development versions of algebra-plugins and detray. |
The corresponding algebra-plugins tag is ready, as is the PR in detray (883) |
2696614
to
41b973c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with this!
But please rename the PR to something more meaningful before we merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can see, traccc::size_type
is only used in the I/O code. 🤔 I would much rather use std::size_t
in those 2 places instead.
213fec1
to
d725c17
Compare
d725c17
to
3971bb1
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This PR seems to slow down the benchmark? |
That's curious. 🤔 |
This is strange indeed, since I was just now working on the detray benchmarks and I am not seeing the same problem... |
Test if the new algebra plugin integration works.
Edit: It turns out that algebra plugins has included the arithmetic operators for
std::array
vector types in the global namespace from where they were picked up in the ACTS VectorHelper by Eigen types. The operators are now moved into the algebra namespace and from there imported into the detray and traccc namspaces.