Spacepoint formation algorithm change

[arkslobodkins]

Changed block size to 256, launching with 1024 threads per block would cause 'too many resources requested for launch' on a desktop GPU.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[krasznaa]

👍

[stephenswat]

Hmm what GPU is this? The kernel is set to be launchable for 1024 threads; perhaps the CUDA architecture you build with (`CMAKE_CUDA_ARCHITECTURES`) does not match the device you are running on?

…

On Wed, 11 Dec 2024, 11:33 sonarcloud[bot], ***@***.***> wrote: [image: Quality Gate Passed] <https://sonarcloud.io/dashboard?id=acts-project_traccc&pullRequest=802> *Quality Gate passed* Issues <https://camo.githubusercontent.com/187ba88c264795e888bdd18141ef29390601e5110d4e9c8cc48f2f8afc183ba0/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f7061737365642d313670782e706e67> 0 New issues <https://sonarcloud.io/project/issues?id=acts-project_traccc&pullRequest=802&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true> <https://camo.githubusercontent.com/86e5c40907bf9e8933fe6bcf185f7076622a76a3bef4b6d2b5fd583959409aef/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f61636365707465642d313670782e706e67> 0 Accepted issues <https://sonarcloud.io/project/issues?id=acts-project_traccc&pullRequest=802&issueStatuses=ACCEPTED> Measures <https://camo.githubusercontent.com/187ba88c264795e888bdd18141ef29390601e5110d4e9c8cc48f2f8afc183ba0/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f7061737365642d313670782e706e67> 0 Security Hotspots <https://sonarcloud.io/project/security_hotspots?id=acts-project_traccc&pullRequest=802&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true> <https://camo.githubusercontent.com/187ba88c264795e888bdd18141ef29390601e5110d4e9c8cc48f2f8afc183ba0/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f7061737365642d313670782e706e67> 0.0% Coverage on New Code <https://sonarcloud.io/component_measures?id=acts-project_traccc&pullRequest=802&metric=new_coverage&view=list> <https://camo.githubusercontent.com/187ba88c264795e888bdd18141ef29390601e5110d4e9c8cc48f2f8afc183ba0/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f7061737365642d313670782e706e67> 0.0% Duplication on New Code <https://sonarcloud.io/component_measures?id=acts-project_traccc&pullRequest=802&metric=new_duplicated_lines_density&view=list> See analysis details on SonarQube Cloud <https://sonarcloud.io/dashboard?id=acts-project_traccc&pullRequest=802> — Reply to this email directly, view it on GitHub <#802 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAI4T7CKNFCWDWK2D4MKN4L2FAIJPAVCNFSM6AAAAABTNEZCVWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMZVGQ3TANRRGU> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[stephenswat]

No, please do not merge this yet

…

On Wed, 11 Dec 2024, 11:49 Stephen Swatman, ***@***.***> wrote: Hmm what GPU is this? The kernel is set to be launchable for 1024 threads; perhaps the CUDA architecture you build with (`CMAKE_CUDA_ARCHITECTURES`) does not match the device you are running on? On Wed, 11 Dec 2024, 11:33 sonarcloud[bot], ***@***.***> wrote: > [image: Quality Gate Passed] > <https://sonarcloud.io/dashboard?id=acts-project_traccc&pullRequest=802> *Quality > Gate passed* > > Issues > > <https://camo.githubusercontent.com/187ba88c264795e888bdd18141ef29390601e5110d4e9c8cc48f2f8afc183ba0/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f7061737365642d313670782e706e67> 0 > New issues > <https://sonarcloud.io/project/issues?id=acts-project_traccc&pullRequest=802&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true> > > <https://camo.githubusercontent.com/86e5c40907bf9e8933fe6bcf185f7076622a76a3bef4b6d2b5fd583959409aef/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f61636365707465642d313670782e706e67> 0 > Accepted issues > <https://sonarcloud.io/project/issues?id=acts-project_traccc&pullRequest=802&issueStatuses=ACCEPTED> > > Measures > > <https://camo.githubusercontent.com/187ba88c264795e888bdd18141ef29390601e5110d4e9c8cc48f2f8afc183ba0/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f7061737365642d313670782e706e67> 0 > Security Hotspots > <https://sonarcloud.io/project/security_hotspots?id=acts-project_traccc&pullRequest=802&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true> > > <https://camo.githubusercontent.com/187ba88c264795e888bdd18141ef29390601e5110d4e9c8cc48f2f8afc183ba0/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f7061737365642d313670782e706e67> 0.0% > Coverage on New Code > <https://sonarcloud.io/component_measures?id=acts-project_traccc&pullRequest=802&metric=new_coverage&view=list> > > <https://camo.githubusercontent.com/187ba88c264795e888bdd18141ef29390601e5110d4e9c8cc48f2f8afc183ba0/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f7061737365642d313670782e706e67> 0.0% > Duplication on New Code > <https://sonarcloud.io/component_measures?id=acts-project_traccc&pullRequest=802&metric=new_duplicated_lines_density&view=list> > > See analysis details on SonarQube Cloud > <https://sonarcloud.io/dashboard?id=acts-project_traccc&pullRequest=802> > > — > Reply to this email directly, view it on GitHub > <#802 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAI4T7CKNFCWDWK2D4MKN4L2FAIJPAVCNFSM6AAAAABTNEZCVWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMZVGQ3TANRRGU> > . > You are receiving this because you are subscribed to this thread.Message > ID: ***@***.***> >

[arkslobodkins]

I believe it's Nvidia RTX 500 Ada Generation Laptop GPU. CMAKE_CUDA_ARCHITECTURES was set to native in my CMakeLists so that flag should have propagated to traccc. Setting threads to 256 solves the issue...

[stephenswat]

...

…

On Wed, 11 Dec 2024, 12:10 Attila Krasznahorkay, ***@***.***> wrote: Merged #802 <#802> into main. — Reply to this email directly, view it on GitHub <#802 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAI4T7CQGCWBUFUBPMYKJUT2FAMTXAVCNFSM6AAAAABTNEZCVWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVGYYTMMZXGM4DINA> . You are receiving this because you commented.Message ID: ***@***.***>