Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Thrust from the core and common libraries #815

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

stephenswat
Copy link
Member

This commit removes the Thrust dependency from both the core and common libraries. As a requirement for this, I had to turn the common device code into a header-only interface library, which is a good idea regardless. The advantage of this is that it makes it much easier to manage the dependencies on Thrust.

Depends on #814.

@stephenswat stephenswat added build This relates to the build system cleanup Makes the code all clean and tidy labels Jan 21, 2025
@stephenswat stephenswat force-pushed the fix/expel_thrust branch 4 times, most recently from 1abe09f to 1cbc38e Compare January 22, 2025 13:27
@stephenswat stephenswat added refactor Change the structure of the code and removed cleanup Makes the code all clean and tidy labels Jan 22, 2025
@stephenswat stephenswat force-pushed the fix/expel_thrust branch 2 times, most recently from 20a2f7a to f442ba4 Compare January 22, 2025 16:10
This commit removes the Thrust dependency from both the core and common
libraries. As a requirement for this, I had to turn the common device
code into a header-only interface library, which is a good idea
regardless. The advantage of this is that it makes it much easier to
manage the dependencies on Thrust.
@stephenswat stephenswat marked this pull request as ready for review January 22, 2025 19:00
@stephenswat stephenswat merged commit ef23946 into acts-project:main Jan 22, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build This relates to the build system refactor Change the structure of the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants