Fix several SYCL, OneDPL, and Kokkos build issues #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenswat
added
bug
It turns out that the SYCL build system is in a significantly worse state than I though it was, and needs some urgent fixing. This commit fixes four primary issues: 1. OneDPL was previously being required as "DPL" but the actual package name is "oneDPL" so it was impossible to find. 2. OneDPL and Kokkos both set a bunch of unwanted interface compiler flags which we need to manually remove. 3. OneDPL cannot be configured with the traccc standard of having a separate C++ compiler and a SYCL compiler, so it needs to be tricked into thinking the SYCL compiler works. 4. OneDPL contains a boatload of compiler warnings which I had to silence with diagnostics pragmas.
stephenswat
force-pushed
the
build/sycl_fixes
branch
from
92fb1dd to
1cb7263
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that the SYCL build system is in a significantly worse state than I though it was, and needs some urgent fixing. This commit fixes four primary issues: