Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several SYCL, OneDPL, and Kokkos build issues #821

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

stephenswat
Copy link
Member

It turns out that the SYCL build system is in a significantly worse state than I though it was, and needs some urgent fixing. This commit fixes four primary issues:

  1. OneDPL was previously being required as "DPL" but the actual package name is "oneDPL" so it was impossible to find.
  2. OneDPL and Kokkos both set a bunch of unwanted interface compiler flags which we need to manually remove.
  3. OneDPL cannot be configured with the traccc standard of having a separate C++ compiler and a SYCL compiler, so it needs to be tricked into thinking the SYCL compiler works.
  4. OneDPL contains a boatload of compiler warnings which I had to silence with diagnostics pragmas.

@stephenswat stephenswat added bug Something isn't working build This relates to the build system sycl Changes related to SYCL kokkos Changes related to Kokkos labels Jan 23, 2025
It turns out that the SYCL build system is in a significantly worse
state than I though it was, and needs some urgent fixing. This commit
fixes four primary issues:

1. OneDPL was previously being required as "DPL" but the actual package
   name is "oneDPL" so it was impossible to find.
2. OneDPL and Kokkos both set a bunch of unwanted interface compiler
   flags which we need to manually remove.
3. OneDPL cannot be configured with the traccc standard of having a
   separate C++ compiler and a SYCL compiler, so it needs to be tricked
   into thinking the SYCL compiler works.
4. OneDPL contains a boatload of compiler warnings which I had to
   silence with diagnostics pragmas.
Copy link
Contributor

@beomki-yeo beomki-yeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@stephenswat stephenswat merged commit 2b3b3cf into acts-project:main Jan 25, 2025
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build This relates to the build system kokkos Changes related to Kokkos sycl Changes related to SYCL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants