Fix global counter conversion issue in Kokkos #823
Merged
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niermann999
approved these changes
Jan 24, 2025
stephenswat
force-pushed
the
fix/kokkos_global_index_cvt
branch
from
9ed3881 to
2b8ca72
Compare
|
PR acts-project#810 added the global index type definition, but missed a spot where this type should have been used in the Kokkos code. This commit amends the issue by adding a static cast.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #810 added the global index type definition, but missed a spot where this type should have been used in the Kokkos code. This commit amends the issue by adding a static cast.