Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete Thrust functionality check #826

Merged

Conversation

stephenswat
Copy link
Member

This check was possibly useful in the past, but now produces spurious warnings. As the code runs fine even without this check on the Thrust installation, the easiest solution is simply to remove it.

@stephenswat stephenswat added build This relates to the build system cleanup Makes the code all clean and tidy labels Jan 29, 2025
@stephenswat stephenswat requested a review from krasznaa January 29, 2025 12:15
Copy link
Member

@krasznaa krasznaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

This check was possibly useful in the past, but now produces spurious
warnings. As the code runs fine even without this check on the Thrust
installation, the easiest solution is simply to remove it.
@stephenswat stephenswat force-pushed the cleanup/remove_dead_check branch from d2497d8 to 3b9ced1 Compare January 29, 2025 16:32
@stephenswat stephenswat enabled auto-merge January 29, 2025 16:32
@stephenswat stephenswat merged commit ac1ff54 into acts-project:main Jan 29, 2025
23 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build This relates to the build system cleanup Makes the code all clean and tidy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants