Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken assertion in prune tracks kernel #828

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

stephenswat
Copy link
Member

Mea culpa, I made a mistake in a recent assertion added to the prune_tracks kernel which was too assertive, requiring an equality relation rather than a greater-or-equal relation between the number of tips and the number of tracks.

@stephenswat stephenswat added bug Something isn't working shared Changes related to shared code labels Jan 29, 2025
Copy link
Member

@krasznaa krasznaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. This time around I guess you runtime tested it. 😛

@stephenswat
Copy link
Member Author

This time around I guess you runtime tested it. 😛

Of course not. :D

Mea culpa, I made a mistake in a recent assertion added to the
`prune_tracks` kernel which was too assertive, requiring an equality
relation rather than a greater-or-equal relation between the number of
tips and the number of tracks.
@stephenswat stephenswat force-pushed the fix/prune_tracks_assert branch from 3d2cb5d to 47a016d Compare January 30, 2025 11:40
@stephenswat stephenswat enabled auto-merge January 30, 2025 11:40
@stephenswat stephenswat merged commit 83ed64e into acts-project:main Jan 30, 2025
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working shared Changes related to shared code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants