Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Thrust a private dependency of the CUDA library #829

Merged

Conversation

stephenswat
Copy link
Member

This was previously a public dependency due to a lingering include of the Thrust pair code in a header, but this dependency is no longer necessary. Thus, we can remove the include from the header file and thereby turn Thrust into a private dependency of the CUDA library. This should also fix the install interface, which is currently broken due to the lack of Thrust setup code.

@stephenswat stephenswat added bug Something isn't working build This relates to the build system labels Jan 29, 2025
@stephenswat stephenswat force-pushed the build/cuda_thrust_private branch from 5662315 to 24b844c Compare January 30, 2025 16:17
Copy link
Member

@krasznaa krasznaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

This was previously a public dependency due to a lingering include of
the Thrust pair code in a header, but this dependency is no longer
necessary. Thus, we can remove the include from the header file and
thereby turn Thrust into a private dependency of the CUDA library. This
should also fix the install interface, which is currently broken due to
the lack of Thrust setup code.
@stephenswat stephenswat force-pushed the build/cuda_thrust_private branch from 24b844c to e8ce98a Compare January 31, 2025 09:41
@stephenswat stephenswat enabled auto-merge January 31, 2025 09:41
@stephenswat stephenswat merged commit 75b72c5 into acts-project:main Jan 31, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build This relates to the build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants