Make Thrust a private dependency of the CUDA library #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenswat
added
bug
stephenswat
force-pushed
the
build/cuda_thrust_private
branch
from
5662315 to
24b844c
Compare
This was previously a public dependency due to a lingering include of the Thrust pair code in a header, but this dependency is no longer necessary. Thus, we can remove the include from the header file and thereby turn Thrust into a private dependency of the CUDA library. This should also fix the install interface, which is currently broken due to the lack of Thrust setup code.
stephenswat
force-pushed
the
build/cuda_thrust_private
branch
from
24b844c to
e8ce98a
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was previously a public dependency due to a lingering include of the Thrust pair code in a header, but this dependency is no longer necessary. Thus, we can remove the include from the header file and thereby turn Thrust into a private dependency of the CUDA library. This should also fix the install interface, which is currently broken due to the lack of Thrust setup code.