Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code for per-commit benchmarking #831

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

stephenswat
Copy link
Member

This PR adds a bunch of code to the extras directory with the code that I used to plot the performance of individual kernels over the course of the repository's history, e.g.:

test

@stephenswat stephenswat added feature New feature or request extras Changes related to the extras labels Jan 30, 2025
@krasznaa
Copy link
Member

We should definitely add your code to the repository for future, similar debugging sessions.

But something that would be even better, would be to add measurements like this to the CI. 🤔 Similar to what we have already on: https://github.com/acts-project/traccc/blob/main/.github/workflows/benchmarks.yml Which is obviously not as good as it should be. 😭

If we could make "your kind of" plots automatically, that would be the dream... 🤔

@stephenswat
Copy link
Member Author

Hmm yes, agree; I'll have to see if I can implement this in that Gitlab repository!

@beomki-yeo
Copy link
Contributor

Yeah it would be greater if we can see this continuously

Copy link
Member

@krasznaa krasznaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With all that being said, adding a new subdirectory with scripts under extras/ is not a controversial thing. Let's save these scripts of yours!

This PR adds a bunch of code to the extras directory with the code that
I used to plot the performance of individual kernels over the course of
the repository's history.
Copy link

sonarqubecloud bot commented Feb 3, 2025

@stephenswat stephenswat merged commit b763a96 into acts-project:main Feb 3, 2025
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extras Changes related to the extras feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants