Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make traccc::alpaka executables work in pure C++ #832

Merged
merged 13 commits into from
Feb 6, 2025

Conversation

StewMH
Copy link
Contributor

@StewMH StewMH commented Jan 30, 2025

Move device code to utils. Built on work by @CrossR (currently in a private branch with other changes for track fitting).

@stephenswat
Copy link
Member

stephenswat commented Jan 30, 2025

Non-technical point, but GitHub is failing to pick up both @CrossR and your own contribution to this due to I guess your email being unknown to GitHub, and Ryan not being mentioned as a co-author.

If Ryan is responsible for part of this code I'd suggest adding a co-authorship trailer to the end of the commit:

Co-authored-by: Ryan Cross <ryan'semail@example.ac.uk>

@StewMH
Copy link
Contributor Author

StewMH commented Jan 30, 2025

OK, do I need a new commit now? or can that be done on the merge commit?

@stephenswat
Copy link
Member

I can try doing it via the merge commit. 👍

Copy link
Member

@krasznaa krasznaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's talk about this for just a little more...

Copy link
Member

@krasznaa krasznaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, we could go ahead like this. The further design improvements/changes will come later. 😉

Copy link
Member

@krasznaa krasznaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's finally go ahead with this...

@krasznaa krasznaa enabled auto-merge (squash) February 6, 2025 14:01
Copy link

sonarqubecloud bot commented Feb 6, 2025

@krasznaa krasznaa merged commit 1afd55b into acts-project:main Feb 6, 2025
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants