-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make traccc::alpaka executables work in pure C++ #832
Conversation
Non-technical point, but GitHub is failing to pick up both @CrossR and your own contribution to this due to I guess your email being unknown to GitHub, and Ryan not being mentioned as a co-author. If Ryan is responsible for part of this code I'd suggest adding a co-authorship trailer to the end of the commit:
|
OK, do I need a new commit now? or can that be done on the merge commit? |
I can try doing it via the merge commit. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's talk about this for just a little more...
device/alpaka/include/traccc/alpaka/seeding/track_params_estimation.hpp
Outdated
Show resolved
Hide resolved
device/alpaka/include/traccc/alpaka/seeding/track_params_estimation.hpp
Outdated
Show resolved
Hide resolved
device/alpaka/include/traccc/alpaka/seeding/track_params_estimation.hpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, we could go ahead like this. The further design improvements/changes will come later. 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's finally go ahead with this...
… utils. Built on work by Ryan Cross
b8b5ceb
to
427d493
Compare
|
Move device code to utils. Built on work by @CrossR (currently in a private branch with other changes for track fitting).