Use configuration types as SSOT for defaults #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenswat
added
improvement
niermann999
requested changes
Jan 31, 2025
krasznaa
reviewed
Jan 31, 2025
stephenswat
force-pushed
the
impr/config_ssot
branch
from
fda2453 to
2bf58b7
Compare
niermann999
approved these changes
Feb 3, 2025
|
This is another thing that might help the ITk track finding efficiency |
As it stands, some of our default values for configuration parameters, e.g. those of the track finding, have defaults defined both in the configuration type as well as in the corresponding options type in the examples. This is confusing as @paradajzblond discovered today. In this commit, I remove the defaults defined in the examples code and treat the configuration type defaults as the single source of truth for default values.
stephenswat
force-pushed
the
impr/config_ssot
branch
from
2bf58b7 to
6fcc91c
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it stands, some of our default values for configuration parameters, e.g. those of the track finding, have defaults defined both in the configuration type as well as in the corresponding options type in the examples. This is confusing as @paradajzblond discovered today. In this commit, I remove the defaults defined in the examples code and treat the configuration type defaults as the single source of truth for default values.