Increase collection comparison performance #836
Merged
+128
−101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenswat
added
improvement
stephenswat
force-pushed
the
impr/binary_search_comparators
branch
from
e8d8720 to
b4ffd16
Compare
krasznaa
reviewed
Feb 3, 2025
Although the collection comparison code is not performance-critical, it is still very, very slow. In part, this is because it is written very naively. This commit improves the performance of this code by several orders of magnitude by sorting the collections, and by avoiding checks for elements which have already been matched at a lower uncertainty level. After these optimisations, it turned out that the Iterators-based progress bar was the performance-limiting factor, so I had to remove that as well.
stephenswat
force-pushed
the
impr/binary_search_comparators
branch
from
b4ffd16 to
56c5dad
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the collection comparison code is not performance-critical, it is still very, very slow. In part, this is because it is written very naively. This commit improves the performance of this code by several orders of magnitude by sorting the collections, and by avoiding checks for elements which have already been matched at a lower uncertainty level. After these optimisations, it turned out that the Iterators-based progress bar was the performance-limiting factor, so I had to remove that as well.
We can now do GPU-vs-CPU physics comparisons for pile-up 200 events in a fraction of a second. 😄