ref: update detray to v0.88.1 #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niermann999
force-pushed
the
ref-update-detray
branch
from
6ae68e4 to
077cc64
Compare
beomki-yeo
reviewed
Feb 4, 2025
niermann999
force-pushed
the
ref-update-detray
branch
from
715efb8 to
e680a64
Compare
niermann999
force-pushed
the
ref-update-detray
branch
11 times, most recently
from
ef634a9 to
02b3b41
Compare
niermann999
force-pushed
the
ref-update-detray
branch
3 times, most recently
from
a3eeb14 to
2bfaa59
Compare
niermann999
changed the title
niermann999
force-pushed
the
ref-update-detray
branch
5 times, most recently
from
068a9a8 to
d730e0b
Compare
stephenswat
reviewed
Feb 14, 2025
niermann999
force-pushed
the
ref-update-detray
branch
3 times, most recently
from
8bc5f92 to
c70646f
Compare
niermann999
force-pushed
the
ref-update-detray
branch
from
51bd42e to
8eb61a5
Compare
|
stephenswat
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to the new detray version. I also made sure that the traccc custom scalar type is handed through to detray, so that it will be built in double precision when required. Apart from that, I removed a detray thrust related cmake variable, which doesn't exist anymore.
The Kalman Fit actor state was switched to use the non-owning
vecmem::device_vectortype always, since it just needs a view on the track states returned from the CKF and the detray detector no longer provides a host/device vector type publicly.