-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the default smoother to two-filters smoother #842
Conversation
Yeah it's not working for the drift chamber where the navigation can get unstable. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay... Let's treat this as a quick fix to the observed issue.
What I'll (or somebody else will) do is to introduce traccc::opts::track_finding
, to make this (and the other track finding options) configurable from the command line. As it really should be...
This kills the performance a bit but it is expected as propagation runs twice.. |
"A bit" may be a bit of an understatement unfortunately. 😭 Lately our code has slowed down a lot... Something to be discussed in tomorrow's meeting. |
It's a drop from correcting the mathematics so... take it as a necessary evil.. |
And KF will be trivial once we implement the ambinsolver after CKF. If i am correct, KF is used in refitting only |
This will fix the issue on bad matching rate between CPU and GPU, reported by @stephenswat and @krasznaa