-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration Updates, main branch (2025.02.07.) #845
Configuration Updates, main branch (2025.02.07.) #845
Conversation
At the same time switched to using the ODD by default for the detector geometry, and input files. Fixed a mistake in traccc::opts::track_finding.
Added it to all the appropriate example applications.
|
@@ -80,48 +79,38 @@ track_finding::operator finding_config() const { | |||
out.ptc_hypothesis = | |||
detail::particle_from_pdg_number<traccc::scalar>(m_pdg_number); | |||
|
|||
return m_config; | |||
return out; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take note that some of the track finding options could not be set from the command line so far. This was a sneaky little bug. (Though not a super important one for the moment.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. 👍
std::string detector_file = | ||
"geometries/odd/odd-detray_geometry_detray.json"; | ||
/// The file containing the material description | ||
std::string material_file; | ||
std::string material_file = | ||
"geometries/odd/odd-detray_material_detray.json"; | ||
/// The file containing the surface grid description | ||
std::string grid_file; | ||
std::string grid_file = | ||
"geometries/odd/odd-detray_surface_grids_detray.json"; | ||
/// Use detray::detector for the geometry handling | ||
bool use_detray_detector = false; | ||
bool use_detray_detector = true; | ||
|
||
/// The digitization configuration file | ||
std::string digitization_file = | ||
"tml_detector/default-geometric-config-generic.json"; | ||
"geometries/odd/odd-digi-geometric-config.json"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea!
Today I tried building traccc with g++12 which broke as acts-project#845 introduced a dependency on `std::format` which is not universally available. In order to provide earlier and more readable errors, this commit adds a configuration-time check to ensure that the C++ compiler supports `std::format`.
This is a replacement for #837. Abandoning changing the classes in
traccc::utils
, and only focusing on thetraccc::opts::
classes.I made (pretty much) the same updates in the existing classes as in #837. And then added the following:
traccc::opts::detector
andtraccc::opts::input_data
to use ODD muon simulations by default. To make it a bit easier to test the code. (As we mostly use ODD data for that.)traccc::opts::track_fitting
, to make the track fitting options configurable. Notably, with the update, I would see:Versus the default: