Configuration Updates, main branch (2025.02.07.) #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the same time switched to using the ODD by default for the detector geometry, and input files. Fixed a mistake in traccc::opts::track_finding.
Added it to all the appropriate example applications.
|
krasznaa
commented
Feb 7, 2025
| @@ -80,48 +79,38 @@ track_finding::operator finding_config() const { | |||
| out.ptc_hypothesis = | |||
| detail::particle_from_pdg_number<traccc::scalar>(m_pdg_number); | |||
|
|
|||
| return m_config; | |||
| return out; | |||
There was a problem hiding this comment.
Take note that some of the track finding options could not be set from the command line so far. This was a sneaky little bug. (Though not a super important one for the moment.)
stephenswat
approved these changes
Feb 7, 2025
Comment on lines
+26
to
+39
| std::string detector_file = | ||
| "geometries/odd/odd-detray_geometry_detray.json"; | ||
| /// The file containing the material description | ||
| std::string material_file; | ||
| std::string material_file = | ||
| "geometries/odd/odd-detray_material_detray.json"; | ||
| /// The file containing the surface grid description | ||
| std::string grid_file; | ||
| std::string grid_file = | ||
| "geometries/odd/odd-detray_surface_grids_detray.json"; | ||
| /// Use detray::detector for the geometry handling | ||
| bool use_detray_detector = false; | ||
| bool use_detray_detector = true; | ||
|
|
||
| /// The digitization configuration file | ||
| std::string digitization_file = | ||
| "tml_detector/default-geometric-config-generic.json"; | ||
| "geometries/odd/odd-digi-geometric-config.json"; |
stephenswat
added a commit
to stephenswat/traccc
that referenced
this pull request
Feb 25, 2025
Today I tried building traccc with g++12 which broke as acts-project#845 introduced a dependency on `std::format` which is not universally available. In order to provide earlier and more readable errors, this commit adds a configuration-time check to ensure that the C++ compiler supports `std::format`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a replacement for #837. Abandoning changing the classes in
traccc::utils, and only focusing on thetraccc::opts::classes.I made (pretty much) the same updates in the existing classes as in #837. And then added the following:
traccc::opts::detectorandtraccc::opts::input_datato use ODD muon simulations by default. To make it a bit easier to test the code. (As we mostly use ODD data for that.)traccc::opts::track_fitting, to make the track fitting options configurable. Notably, with the update, I would see:Versus the default: