Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track Parameter CSV Writing, main branch (2025.02.10.) #849

Closed

Conversation

krasznaa
Copy link
Member

While debugging the issue fixed in #848, I wrote this code for dumping the properties of reconstructed bound track parameters.

While detray::bound_track_parameters has a print operator itself (which I'm very much on board with, and could've technically used for this debugging as well...), I thought this code may still be good to preserve. It could come in handy in some future debugging sessions as well. 🤔

@krasznaa krasznaa added the feature New feature or request label Feb 10, 2025
Copy link
Contributor

@niermann999 niermann999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must say, that I am not completely happy of doing free track param csv IO in detray (https://github.com/acts-project/detray/blob/main/io/include/detray/io/csv/track_parameters.hpp) and bound track param IO in traccc. I think, it would be better to keep the IO implementation of detray types bundled in one place. Sooner or later, somebody decides this is needed for some detray debugging as well, and nobody remembers that traccc has this implemented and then we have two versions...
Besides, detray io is already a traccc dependency, right? So, it should not be too difficult to extend/adapt the detray implementation of the csv IO and then adding an interface for the traccc container types?

@krasznaa
Copy link
Member Author

I was not aware of the CSV capabilities in Detray...

Sure, I think it's fair that such "pure Detray collections" would have I/O code in Detray. I'll see how to port this code into that project...

@krasznaa krasznaa closed this Feb 10, 2025
@niermann999
Copy link
Contributor

I was not aware of the CSV capabilities in Detray...

Sure, I think it's fair that such "pure Detray collections" would have I/O code in Detray. I'll see how to port this code into that project...

If that is possible, that would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants