Minor fixes to the track building kernel #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch. Could you fix the same bugs in CPU code: https://github.com/acts-project/traccc/blob/main/core/include/traccc/finding/details/find_tracks.hpp ? |
Ah yes, of course! |
stephenswat
force-pushed
the
fix/build_tracks
branch
from
bca39f4 to
7689fc7
Compare
|
There we go! 😄 |
stephenswat
force-pushed
the
fix/build_tracks
branch
from
7689fc7 to
e588c4b
Compare
|
Clearly this warrants some more investigation... 🤔 |
stephenswat
added a commit
to stephenswat/traccc
that referenced
this pull request
Feb 13, 2025
While debugging the CI failures in acts-project#859, I found out that the problem was not with my code, but rather that there is a critical failure with the use of `std::forward` in `host_container.cpp`, which causes objects passed to `push_back` as l-value references to be inadvertently converted to r-value references. This commit fixes the bug in `host_container.hpp`. The `nseed_performance_writer.cpp` contained a much less serious mistake which I also fixed.
stephenswat
force-pushed
the
fix/build_tracks
branch
from
e588c4b to
82fc14d
Compare
This commit makes some minor fixes and improvements to the track building kernel. In particular, it: 1. Fixes an error where we were comparing measurements indices to see if they were _larger_ than the total number of measurements, but they should be check also for _equality_. 2. Fail more gracefully if we cannot find any true measurements, i.e. register the failed track as a candidate for pruning. 3. Simplify the control flow of the kernel by removing an unnecessary break statement.
stephenswat
force-pushed
the
fix/build_tracks
branch
from
82fc14d to
bcd8fdd
Compare
|
I will update the branch by myself and merge it once the CI passes |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes some minor fixes and improvements to the track building kernel. In particular, it: